Replace String.join with String.repeat for generating placeholders in TableMetaDataContext
#33364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…holders Replaced the use of String.join combined with Collections.nCopies to generate SQL placeholders with the more concise and efficient String.repeat method. - This change simplifies the code and improves readability. - Performance might be slightly improved as String.repeat is more direct. No functionality change; only a refactoring to improve code clarity and efficiency. Benchmark Mode Cnt Score Error Units JoinTest.nCopies thrpt 5 5938.720 ± 84.293 ops/ms JoinTest.repeat thrpt 5 37268.560 ± 1977.043 ops/ms
|
@luckygc Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@luckygc Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
changed the title
String.join with String.repeat for generating placeholders in TableMetaDataContext
bclozel
added
status: declined
sbrannen
added
in: data
|
@sbrannen Thank you for the guidance. I understand now and will make sure to push additional commits to the existing PR next time instead of creating a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the use of String.join combined with Collections.nCopies to generate SQL placeholders with the more concise and efficient String.repeat method.
No functionality change; only a refactoring to improve code clarity and efficiency.
Benchmark Mode Cnt Score Error Units
JoinTest.nCopies thrpt 5 5938.720 ± 84.293 ops/ms
JoinTest.repeat thrpt 5 37268.560 ± 1977.043 ops/ms